[Help] Autoconf issue in nstreams

[Andreas Tille]

Hi,

I think I've solved the original autoconf issue that was causing bug
#1075323 and also fixed some missing includes. However, there is some
remaining issue since autoheader creates some broken includes/config.h
file which does not contain the necessary definitions leading to

nstreams.c:100:34: error: 'VERSION' undeclared (first use in this function)
100 | printf("This is nstreams %s\n", VERSION);
| ^~~~~~~
nstreams.c:100:34: note: each undeclared identifier is reported only once for each function it appears in
nstreams.c: In function 'main':
nstreams.c:140:23: error: 'ETC_NSTREAMS_SERVICES' undeclared (first use in this function)
140 | char * config_file = ETC_NSTREAMS_SERVICES;
| ^~~~~~~~~~~~~~~~~~~~~
nstreams.c:141:20: error: 'ETC_NSTREAMS_NETWORKS' undeclared (first use in this function)
141 | char * networks = ETC_NSTREAMS_NETWORKS;
| ^~~~~~~~~~~~~~~~~~~~~

I've injected the packaging into Salsa[1] and you can see the full
build log in Salsa CI[2].

Any help is welcome
Andreas.


[1] https://salsa.debian.org/salvage-team/nstreams
[2] https://salsa.debian.org/salvage-team/nstreams/-/jobs/6735273

[наб]

Post by Andreas Tille
I think I've solved the original autoconf issue that was causing bug
#1075323 and also fixed some missing includes. However, there is some
remaining issue since autoheader creates some broken includes/config.h
file which does not contain the necessary definitions leading to
nstreams.c:100:34: error: 'VERSION' undeclared (first use in this function)
100 | printf("This is nstreams %s\n", VERSION);
| ^~~~~~~
nstreams.c:100:34: note: each undeclared identifier is reported only once for each function it appears in
nstreams.c:140:23: error: 'ETC_NSTREAMS_SERVICES' undeclared (first use in this function)
140 | char * config_file = ETC_NSTREAMS_SERVICES;
| ^~~~~~~~~~~~~~~~~~~~~
nstreams.c:141:20: error: 'ETC_NSTREAMS_NETWORKS' undeclared (first use in this function)
141 | char * networks = ETC_NSTREAMS_NETWORKS;
| ^~~~~~~~~~~~~~~~~~~~~

This was due to nstreams ships an aclocal.m4 that shadows some(?) macros
that autohell uses internally.

Patching out aclocal.m4 (and turning the one VERSION user into
PACKAGE_VERSION) fixed it.